qutebrowser: add quickmark support #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rycee
reviewed
May 31, 2021
rycee
reviewed
May 31, 2021
Comment on lines
+295
to
+296
| quickmarksFile = optionals (cfg.quickmarks != { }) concatStringsSep "\n" | ||
| ((mapAttrsToList formatQuickmarks cfg.quickmarks)); |
There was a problem hiding this comment.
Hmm, isn't the ( in the wrong place? I would have expected
Suggested change
| quickmarksFile = optionals (cfg.quickmarks != { }) concatStringsSep "\n" | |
| ((mapAttrsToList formatQuickmarks cfg.quickmarks)); | |
| quickmarksFile = optionals (cfg.quickmarks != { }) (concatStringsSep "\n" | |
| (mapAttrsToList formatQuickmarks cfg.quickmarks)); |
There was a problem hiding this comment.
Me as well, and that's how I initially wrote it. The format utility converted it to this, so i assumed that is prefered.
There was a problem hiding this comment.
Oh, optionals doesn't check whether the last argument is actually a list so it returns whatever is on the right, in this case the function concatStringsSep, which is then invoked with the rest.
{
optionals =
# Condition
cond:
# List to return if condition is true
elems: if cond then elems else [];
}
|
Thanks! Looks OK to me. Just had two minor comments. |
IvarWithoutBones
force-pushed
the
fix/qutebrowser-quickmarks
branch
from
78893d5 to
bcf004d
Compare
|
Would love to get this merged :) |
IvarWithoutBones
added a commit
to IvarWithoutBones/dotfiles
that referenced
this pull request
Jun 15, 2021
This is now possible as nix-community/home-manager#2059 got merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1230
Description
This allows the qutebrowser derivation to parse quickmarks, which I've been wanting to use for a while. If unset, qutebrowser will manage the file instead of home-manager.
When quickmarks are set through home-manager, they cannot be edited at runtime.
Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.