i3: Default workspace & Workspace output assignment

[SebTM]

Description

Hello,

I'm a new to NixOS (and also nix, home-manager and the whole ecosystem). This is my first contribution after I tried to build my personal I3-config with home-manager and found some cases I was not able to do.

If there is a need I'm happy to adjust, please describe/comment in the code :-)
I tried my best to follow the contribution-guidelines and the checklist - if I missed something please inform me.

Cheers!

Possibly related to #695 but does not solve it completely.

Checklist

• Change is backwards compatible.

• Code formatted with ./format.

• Code tested through nix-shell --pure tests -A run.all.

• Test cases updated/added. See example.

• Commit messages are formatted like

  {component}: {description}
  
  {long description}
  

[sumnerevans]

Could you make this more generic so that it can be used in sway as well? I think that would involve moving more of the functions and the options to the lib folder.

[sumnerevans]

I think it would be good to split this into two PRs:

• add defaultWorkspace option.
• add workspaceOutputAssign option.

I agree with @rycee that it doesn't make much sense to have the variables option since that should be handled by Nix variables.

[rycee]

Please mind the commit message length, the subject line should at most 60 characters, ideally 50. At the moment it seems to be 172 characters.

[SebTM]

Thanks for your Feedback!

• I moved the options to the lib-files
• I removed the variables option as it was really not needed, a "miss-thinking" in the first try I guess :)
• I adjusted the description to something more understandable
• I adjusted the commit message

I don't see the advantage of introducing a sortOrder to keybindings as there is no real impact on the rest of the orders as far as I found out? (and more complexity?)

If you give me feedback to just split up the PR, I'm happy to do this, until everything is ok it's easier for me just to keep up2date one :)

[sumnerevans]

Sorry for the delay getting back to this. I think it looks pretty good now. Let's go ahead and split it up into two PRs so that they are a bit easier to handle.

[SebTM]

No Problem, spitted into two PRs mentioned this :-)