Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starship: improve zsh terminal check #1821

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Starship: improve zsh terminal check #1821

merged 1 commit into from
Feb 23, 2021

Conversation

pnotequalnp
Copy link
Contributor

@pnotequalnp pnotequalnp commented Feb 22, 2021

Matches zsh's check with bash and fish, checking for a dumb terminal and
allowing vterm inside Emacs.

See #1238 and #1248

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

Matches zsh's check with bash and fish, checking for a dumb terminal and
allowing vterm inside Emacs.
@teto teto merged commit 0933fb8 into nix-community:master Feb 23, 2021
malte-v pushed a commit to malte-v/home-manager that referenced this pull request Feb 24, 2021
Matches zsh's check with bash and fish, checking for a dumb terminal and
allowing vterm inside Emacs.
aakropotkin pushed a commit to aakropotkin/home-manager that referenced this pull request Feb 28, 2021
Matches zsh's check with bash and fish, checking for a dumb terminal and
allowing vterm inside Emacs.
cab404 pushed a commit to cab404/home-manager that referenced this pull request Apr 23, 2021
Matches zsh's check with bash and fish, checking for a dumb terminal and
allowing vterm inside Emacs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants