fzf: remove non-working historyWidgetCommand option #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The environment variable FZF_CTRL_R_COMMAND has never existed according to `git grep FZF_CTRL_R_COMMAND $(git rev-list --all)` and `git log -G FZF_CTRL_R_COMMAND`.
malte-v
pushed a commit
to malte-v/home-manager
that referenced
this pull request
Feb 24, 2021
The environment variable FZF_CTRL_R_COMMAND has never existed and been support by fzf according to `git grep FZF_CTRL_R_COMMAND $(git rev-list --all)` and `git log -G FZF_CTRL_R_COMMAND`.
aakropotkin
pushed a commit
to aakropotkin/home-manager
that referenced
this pull request
Feb 28, 2021
The environment variable FZF_CTRL_R_COMMAND has never existed and been support by fzf according to `git grep FZF_CTRL_R_COMMAND $(git rev-list --all)` and `git log -G FZF_CTRL_R_COMMAND`.
cab404
pushed a commit
to cab404/home-manager
that referenced
this pull request
Apr 23, 2021
The environment variable FZF_CTRL_R_COMMAND has never existed and been support by fzf according to `git grep FZF_CTRL_R_COMMAND $(git rev-list --all)` and `git log -G FZF_CTRL_R_COMMAND`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1020
Description
The environment variable FZF_CTRL_R_COMMAND has never existed
according to
git grep FZF_CTRL_R_COMMAND $(git rev-list --all)and
git log -G FZF_CTRL_R_COMMAND.This PR marks the option
historyWidgetCommandas removed and removes all associated logic.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.