rofi: migrate to rasi configuration format #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiagokokada
force-pushed
the
migrate-rofi-to-rasi
branch
from
eddd56c to
f47c4ee
Compare
thiagokokada
commented
Jan 20, 2021
| @@ -72,20 +72,14 @@ let | |||
| }; | |||
|
|
|||
| valueToString = value: | |||
| if isBool value then (if value then "true" else "else") else toString value; | |||
There was a problem hiding this comment.
This was a bug in the old code, when you set the value to false it wrote else to config instead.
|
Don't know what is failing in CI, both |
thiagokokada
force-pushed
the
migrate-rofi-to-rasi
branch
from
f47c4ee to
6e79670
Compare
Yes, this is/was an issue on nixpkgs-unstable with kakoune due to a treewide refactor of stdenv.lib -> lib, the failing CI will only be resolved when the nixpkgs channel used in the CI is updated (which is automatic IIRC). |
thiagokokada
force-pushed
the
migrate-rofi-to-rasi
branch
from
6e79670 to
de5c06e
Compare
|
Removed the unnecessary blank lines from the result config file, also changed some function names to match their names in the |
The Xresources configuration format is deprecated in Rofi. For example, using Rofi from unstable (1.6.1 as of now) you get the following warnings when starting the application: ``` (process:9272): Rofi-WARNING **: 01:38:48.596: The old Xresources based configuration format is deprecated. (process:9272): Rofi-WARNING **: 01:38:48.596: Please upgrade: rofi -upgrade-config. `````` So this commit migrates it for its new configuration format, called rasi instead. This new implementation uses attrsets manipulation instead of using strings, making the code clearer and also fixing some bugs found during the way. To make sure everything is right, I also created some tests. If someone wants to validate if the generated config is correct, just run in terminal: ``` $ rofi -dump-config ``` And rofi will dump the current configuration file, including all unsetted options.
thiagokokada
force-pushed
the
migrate-rofi-to-rasi
branch
from
de5c06e to
d84d6b2
Compare
|
Rebased with master and add myself as maintainer. I think now the tests should pass. |
thiagokokada
force-pushed
the
migrate-rofi-to-rasi
branch
from
d84d6b2 to
ee12015
Compare
berbiche
reviewed
Jan 22, 2021
thiagokokada
force-pushed
the
migrate-rofi-to-rasi
branch
2 times, most recently
from
cb7de66 to
75fab73
Compare
thiagokokada
force-pushed
the
migrate-rofi-to-rasi
branch
from
75fab73 to
79077e8
Compare
thiagokokada
added a commit
to thiagokokada/home-manager
that referenced
this pull request
Feb 10, 2021
* rofi: migrate to rasi configuration format The Xresources configuration format is deprecated in Rofi. For example, using Rofi from unstable (1.6.1 as of now) you get the following warnings when starting the application: ``` (process:9272): Rofi-WARNING **: 01:38:48.596: The old Xresources based configuration format is deprecated. (process:9272): Rofi-WARNING **: 01:38:48.596: Please upgrade: rofi -upgrade-config. `````` So this commit migrates it for its new configuration format, called rasi instead. This new implementation uses attrsets manipulation instead of using strings, making the code clearer and also fixing some bugs found during the way. To make sure everything is right, I also created some tests. If someone wants to validate if the generated config is correct, just run in terminal: ``` $ rofi -dump-config ``` And rofi will dump the current configuration file, including all unsetted options. * docs: document programs.rofi.extraConfig changes * rofi: add thiagokokada as maintainer * rofi: add toRasi function
malte-v
pushed a commit
to malte-v/home-manager
that referenced
this pull request
Feb 24, 2021
* rofi: migrate to rasi configuration format The Xresources configuration format is deprecated in Rofi. For example, using Rofi from unstable (1.6.1 as of now) you get the following warnings when starting the application: ``` (process:9272): Rofi-WARNING **: 01:38:48.596: The old Xresources based configuration format is deprecated. (process:9272): Rofi-WARNING **: 01:38:48.596: Please upgrade: rofi -upgrade-config. `````` So this commit migrates it for its new configuration format, called rasi instead. This new implementation uses attrsets manipulation instead of using strings, making the code clearer and also fixing some bugs found during the way. To make sure everything is right, I also created some tests. If someone wants to validate if the generated config is correct, just run in terminal: ``` $ rofi -dump-config ``` And rofi will dump the current configuration file, including all unsetted options. * docs: document programs.rofi.extraConfig changes * rofi: add thiagokokada as maintainer * rofi: add toRasi function
aakropotkin
pushed a commit
to aakropotkin/home-manager
that referenced
this pull request
Feb 28, 2021
* rofi: migrate to rasi configuration format The Xresources configuration format is deprecated in Rofi. For example, using Rofi from unstable (1.6.1 as of now) you get the following warnings when starting the application: ``` (process:9272): Rofi-WARNING **: 01:38:48.596: The old Xresources based configuration format is deprecated. (process:9272): Rofi-WARNING **: 01:38:48.596: Please upgrade: rofi -upgrade-config. `````` So this commit migrates it for its new configuration format, called rasi instead. This new implementation uses attrsets manipulation instead of using strings, making the code clearer and also fixing some bugs found during the way. To make sure everything is right, I also created some tests. If someone wants to validate if the generated config is correct, just run in terminal: ``` $ rofi -dump-config ``` And rofi will dump the current configuration file, including all unsetted options. * docs: document programs.rofi.extraConfig changes * rofi: add thiagokokada as maintainer * rofi: add toRasi function
cab404
pushed a commit
to cab404/home-manager
that referenced
this pull request
Apr 23, 2021
* rofi: migrate to rasi configuration format The Xresources configuration format is deprecated in Rofi. For example, using Rofi from unstable (1.6.1 as of now) you get the following warnings when starting the application: ``` (process:9272): Rofi-WARNING **: 01:38:48.596: The old Xresources based configuration format is deprecated. (process:9272): Rofi-WARNING **: 01:38:48.596: Please upgrade: rofi -upgrade-config. `````` So this commit migrates it for its new configuration format, called rasi instead. This new implementation uses attrsets manipulation instead of using strings, making the code clearer and also fixing some bugs found during the way. To make sure everything is right, I also created some tests. If someone wants to validate if the generated config is correct, just run in terminal: ``` $ rofi -dump-config ``` And rofi will dump the current configuration file, including all unsetted options. * docs: document programs.rofi.extraConfig changes * rofi: add thiagokokada as maintainer * rofi: add toRasi function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Xresources configuration format is deprecated in Rofi. For example, using Rofi from unstable (1.6.1 as of now) you get the following warnings when starting the application:
So this commit migrates it for its new configuration format, called rasi instead.
This new implementation uses attrsets manipulation instead of using strings, making the code clearer and also fixing some bugs found during the way. This is mostly an implementation detail though, since this change is mostly backwards compatible with the old one (the only option that is not backwards compatible is
programs.rofi.extraConfig, but this would break anyway since the textual format changed). To make sure everything is right, I also created some tests.If someone wants to validate if the generated config is correct, just run in terminal:
And rofi will dump the current configuration file, including all unsetted options.
Closes issue #1593.
Checklist
Change is backwards compatible. (mostly, except for
programs.rofi.extraConfigthat is documented)Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
Added myself as module maintainer. See example.
Added myself and the module files to
.github/CODEOWNERS.