Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devilspie2: add module #1477

Merged
merged 7 commits into from
Jul 5, 2021
Merged

devilspie2: add module #1477

merged 7 commits into from
Jul 5, 2021

Conversation

dawidsowa
Copy link
Contributor

Description

Adds Devilspie2 as a service.

It's useful for window managers with limited options for windows rules, such as mutter (gnome).

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

    • Added myself and the module files to .github/CODEOWNERS.

@dawidsowa dawidsowa requested a review from rycee as a code owner September 6, 2020 22:17
Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
If you could add a simple test like the one from sxhkd it would be great 👍

@stale
Copy link

stale bot commented Apr 28, 2021

Thank you for your contribution! I marked this pull request as stale due to inactivity. If this remains inactive for another 7 days, I will close this PR. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously, when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the issue

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Apr 28, 2021
@stale stale bot closed this May 5, 2021
@sumnerevans
Copy link
Member

Reopening. Looks like this was pretty close to done.

@sumnerevans sumnerevans reopened this May 9, 2021
@stale stale bot removed the status: stale label May 9, 2021
@sumnerevans sumnerevans requested a review from berbiche May 9, 2021 21:43
Copy link
Member

@sumnerevans sumnerevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of nits. Sorry for the delay getting back to you on this!

.github/CODEOWNERS Show resolved Hide resolved
modules/services/devilspie2.nix Outdated Show resolved Hide resolved
modules/services/devilspie2.nix Outdated Show resolved Hide resolved
Comment on lines 2 to 3
devilspie2-configuration = ./configuration.nix;
devilspie2-service = ./service.nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like these tests can be combined into one, but I think it would be fine to leave separate as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, these tests should be combined.

Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good 😄.

Would you mind merging the tests together?
While these tests should be independent, the nature of the test utility makes it that running a test and evaluating it is non-trivial, increasing the time it takes to evaluate the entire test suite.

Comment on lines 2 to 3
devilspie2-configuration = ./configuration.nix;
devilspie2-service = ./service.nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, these tests should be combined.

@hpfr
Copy link
Contributor

hpfr commented Jun 22, 2021

According to the devilspie2 website, it looks like the current maintainer is looking for a new maintainer, and the last commit was two years ago. Furthermore Gnome has defaulted to Wayland for a while now, and I believe this only works on X. I'm not sure how long Gnome plans to support X11, but the future of this utility is not looking good at the moment?

So you could probably close this if @dawidsowa doesn't happen to come back to it.

modules/modules.nix Outdated Show resolved Hide resolved
Co-authored-by: Nicolas Berbiche <[email protected]>
Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@berbiche berbiche merged commit 97d183e into nix-community:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants