polybar: allow config to be more nix-like #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nadrieril
force-pushed
the
polybar-config
branch
from
889fa64 to
6d16085
Compare
|
Bump |
|
ok can you rebase please ? |
teto
approved these changes
Feb 20, 2021
Nadrieril
force-pushed
the
polybar-config
branch
from
1a2bfe1 to
f11b10e
Compare
|
Done |
Polybar's config format is a bit strange, and lists in particular are annoying to handle. This enables using normal nix lists and nested attrsets instead. This change is not backwards-compatible, because the INI converter converts lists of strings to space-separated values, and this does something else. I expect that this is only relevant for the `modules-left` etc bar setting, but that's enough to break things :(.
Nadrieril
force-pushed
the
polybar-config
branch
from
f11b10e to
ae47bb3
Compare
malte-v
pushed a commit
to malte-v/home-manager
that referenced
this pull request
Feb 24, 2021
Polybar's config format is a bit strange, and lists in particular are annoying to handle. This enables using normal nix lists and nested attrsets instead. This change is not backwards-compatible, because the INI converter converts lists of strings to space-separated values, and this does something else. I expect that this is only relevant for the `modules-left` etc bar setting, but that's enough to break things :(.
aakropotkin
pushed a commit
to aakropotkin/home-manager
that referenced
this pull request
Feb 28, 2021
Polybar's config format is a bit strange, and lists in particular are annoying to handle. This enables using normal nix lists and nested attrsets instead. This change is not backwards-compatible, because the INI converter converts lists of strings to space-separated values, and this does something else. I expect that this is only relevant for the `modules-left` etc bar setting, but that's enough to break things :(.
cab404
pushed a commit
to cab404/home-manager
that referenced
this pull request
Apr 23, 2021
Polybar's config format is a bit strange, and lists in particular are annoying to handle. This enables using normal nix lists and nested attrsets instead. This change is not backwards-compatible, because the INI converter converts lists of strings to space-separated values, and this does something else. I expect that this is only relevant for the `modules-left` etc bar setting, but that's enough to break things :(.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Polybar's config format is a bit strange, and lists in particular are annoying to handle. This enables using normal nix lists and nested attrsets instead.
I had to create a new option because this change would not be backwards-compatible, because the INI converter currently converts lists of strings to space-separated values, and this new option does something else. I expect that this is only relevant for the
modules-leftetc bar setting, but that's enough to break things :(.I'm not sure how to name this new option. I named it
settingsbecause I thought we might decide to deprecateconfigin its favor later.Checklist
Change is backwards compatible.
Code formatted with
./format.Code tested through
nix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.