Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mev-boost module option generation and network options #559

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

ekimber
Copy link
Contributor

@ekimber ekimber commented Dec 16, 2024

Contains the following changes:

  • Remove goerli as it is retired and no longer a valid network option.
  • Fix the cli option generation so that it works with the change in mev-boost v1.8 to use the urfave cli library.

Resolves issue #558
The mev-boost test passes for me now.

Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. thank you

@zimbatm zimbatm merged commit 3cdcda6 into nix-community:main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants