rotki-bin: init at 1.32.1 #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a quick go at building it from source following [the guide] [1], then decided on just wrapping the appimage after running into some python build issues related to the `ruff` linter that was being invoked in a build phase for some reason. I'm sure it's doable with some patching if someone's keen enough, but this at least makes the package available for now. [1]: https://rotki.readthedocs.io/en/latest/installation_guide.html#build-from-source
|
I'll build it from sources, but this first version is good enough :) |
|
The open PR on nixpkgs has some extra packages added to path: https://github.com/NixOS/nixpkgs/pull/281781/files#diff-43d2233c3f4a035c0efd6110ee4189d28f2260ae102c8a3a2ca12ace792b73a4R44-R47 Any idea if these are necessary? |
|
Ahh I didn't see that PR @jhvst - I just checked that the application GUI ran and it was looking good. I'm unsure whether or not there are any deeper runtime issues that might be caused without those on linux? Either way, that nixpkgs PR appears to also support darwin, so would be great to see that extra support landed either in nixpkgs or here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a quick go at building it from source following the guide, then decided on just wrapping the appimage after running into some python build issues related to the
rufflinter that was being invoked in a build phase for some reason. I'm sure it's doable with some patching if someone's keen enough, but this at least makes the package available for now.