Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update packages #474

Merged
merged 4 commits into from
Feb 21, 2024
Merged

chore: update packages #474

merged 4 commits into from
Feb 21, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by the nix-update-actions GitHub Action.

@github-actions github-actions bot force-pushed the chore/nix_update_actions branch from e63332a to 0d11145 Compare February 18, 2024 10:08
@aldoborrero
Copy link
Collaborator

aldoborrero commented Feb 19, 2024 •
edited
Loading

@selfuryon I'm tempted to disable this workflow until PR #468 is finished. I don't think we're losing anything as we need to keep updating this action every so often. Let me know your thoughts.

On second thought, would you mind trying adding the option to the nix-update-action of using updateScript if defined?

@selfuryon selfuryon force-pushed the chore/nix_update_actions branch from 0d11145 to 832584a Compare February 19, 2024 15:53
@github-actions github-actions bot force-pushed the chore/nix_update_actions branch from 832584a to 4c1cfc8 Compare February 20, 2024 10:11
@selfuryon
Copy link
Collaborator

@selfuryon I'm tempted to disable this workflow until PR #468 is finished. I don't think we're losing anything as we need to keep updating this action every so often. Let me know your thoughts.

On second thought, would you mind trying adding the option to the nix-update-action of using updateScript if defined?

Yeah, I agree on disabling this flow, a lot of edge cases for now =\

About use nix-update-actions - yeah, I thought about moving the logic of update.sh and other scripts just to nix-update-actions and use it there, we can do it like that

@selfuryon selfuryon force-pushed the chore/nix_update_actions branch from 4c1cfc8 to 1e158ec Compare February 21, 2024 00:56
selfuryon
selfuryon approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@selfuryon selfuryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@selfuryon selfuryon merged commit e428579 into main Feb 21, 2024
73 checks passed
@selfuryon selfuryon deleted the chore/nix_update_actions branch February 21, 2024 01:40
@MartinNikov MartinNikov mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfuryon selfuryon selfuryon approved these changes

Assignees
No one assigned
Labels
auto-merge automated dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aldoborrero @selfuryon @bottie-mc-bot-face