feat(rocketpool): Add the Rocket Pool CLI

[angaz]

Adds the Rocket Pool CLI to the utils packages.

Regarding the overlayAttrs: when I tried to use the overlay in my nixos config, it didn't work. I had to list out the packages to make it work. I am not sure why this is the case. If someone can tell me if this is known to work, I'd like to see what the nixpkgs.overlays looks like to make it work.

[aldoborrero]

@angaz have you tried with overlays.default?

If you run on ethereum.nix the following command: nix flake show, it will display the following:

├───overlays
│   └───default: Nixpkgs overlay

Can you verify that it works on your machine with that? I don't want to specify manually the list of packages for overlay. Thanks!

[angaz]

Yeah, this is exactly what I'm using with my current changes. Without my changes, it returns errors.

[angaz]

I have this in my base configuration:

  nixpkgs.overlays = [
    ethereum-nix.overlays.default
  ];

With current main branch, there's this error message:

error:
       … while calling the 'head' builtin

         at /nix/store/h93pa4qif40f0hjwrs155ihb3lpf36m7-source/lib/attrsets.nix:820:11:

          819|         || pred here (elemAt values 1) (head values) then
          820|           head values
             |           ^
          821|         else

       … while evaluating the attribute 'value'

         at /nix/store/h93pa4qif40f0hjwrs155ihb3lpf36m7-source/lib/modules.nix:807:9:

          806|     in warnDeprecation opt //
          807|       { value = builtins.addErrorContext "while evaluating the option `${showOption loc}':" value;
             |         ^
          808|         inherit (res.defsFinal') highestPrio;

       (stack trace truncated; use '--show-trace' to show the full trace)

       error: attribute 'i686-linux' missing

       at /nix/store/mww0kbd58ky1ig7a06fmby7ggbjxxghn-source/modules/transposition.nix:63:32:

           62|       mapAttrs
           63|         (attrName: attrConfig: flake.${attrName}.${system})
             |                                ^
           64|         config.transposition;

I have no idea why this is the case. But specifying the list of packages works. I am not so good at the nix language, so I don't know if it's possible to replace this with some kind of map expression.

[aldoborrero]

@angaz you're using the flake for a system with error: attribute 'i686-linux' missing. We only support at the moment the following architectures:

"x86_64-linux"
"aarch64-linux"
"x86_64-darwin"
"aarch64-darwin"

That's why the self'.overlays is not working for you

[angaz]

It's definitely an x86_64 CPU that I have, and building for.

[angaz]

How would the change work if I was building for an unsupported architecture.

Can you please show me your config?

[aldoborrero]

You're correct! Spinning up the nix repl:

We can see the same error that I mistakenly thought you were using the i686 arch:

Researching the root cause to understand why it's happening

[angaz]

Cool. I'm glad it wasn't something weird I did. I looked for the same pattern (without listing all the packages) and didn't find it. But GitHub search is not known to be the best, so maybe it does work somehow? I have no clue. I just changed it to list the packages because that's how it was in the docs, and then it worked. ¯_(ツ)_/¯

[aldoborrero]

I do have other projects using the overlays and there's no error in them (although those projects are not using per-se flakes though). I would like to understand what's going on :)

[angaz]

@aldoborrero any updates on your investigation?

[aldoborrero]

@angaz not yet. I'll try to allocate time this week.

[angaz]

Cool. Just wanted to see if you found anything.

[aldoborrero]

@angaz I'll separate your contribution for adding rocketpool cli (we're discussing about the issue of easyOverlay in this issue #442)

[angaz]

@angaz I'll separate your contribution for adding rocketpool cli (we're discussing about the issue of easyOverlay in this issue #442)

Sure. I can update it and remove the overlay changes.

[aldoborrero]

@angaz yeah, go ahead, #443 will be merged soon

[aldoborrero]

LGTM

[aldoborrero]

@angaz we require the commit to be signed

[angaz]

Ah. Ok I didn't know. I will set up commit signing for next time.