Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prysm): arm support #386

Merged
merged 1 commit into from
Oct 5, 2023
Merged

feat(prysm): arm support #386

merged 1 commit into from
Oct 5, 2023

Conversation

dzmitry-lahoda
Copy link
Contributor

@dzmitry-lahoda dzmitry-lahoda commented Sep 27, 2023 •
edited
Loading

for #284

Seems libs i patched are old, devs improved arm build in master. may be should update.

actions-runner@Ubuntu-2204-jammy-arm64-base:~/github.com/nix-community/ethereum.nix$ nix build .#prysm -L --show-trace
actions-runner@Ubuntu-2204-jammy-arm64-base:~/github.com/nix-community/ethereum.nix$ uname -a
Linux Ubuntu-2204-jammy-arm64-base 5.15.0-83-generic #92-Ubuntu SMP Mon Aug 14 09:34:05 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux
actions-runner@Ubuntu-2204-jammy-arm64-base:~/github.com/nix-community/ethereum.nix$

@dzmitry-lahoda dzmitry-lahoda marked this pull request as draft September 27, 2023 12:29
@dzmitry-lahoda dzmitry-lahoda marked this pull request as ready for review September 27, 2023 14:29
aldoborrero
aldoborrero requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@aldoborrero aldoborrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes are requested that are mostly related to importing directly lib rather than pkgs.lib.

packages/libs/mcl/default.nix Outdated Show resolved Hide resolved
packages/libs/bls/default.nix Outdated Show resolved Hide resolved
@aldoborrero
Copy link
Collaborator

@dzmitry-lahoda thanks for contributing! Apart from the minor changes I requested, would you mind squashing all your commits and updating the commit message to be more like: "feat: add arm support to prysm"?

@dzmitry-lahoda dzmitry-lahoda force-pushed the dz/09/27 branch 2 times, most recently from a030517 to ea2c8de Compare October 3, 2023 15:03
@dzmitry-lahoda
feat: add arm support for prysm
f219bba 
feat: add arm support for prysm
@aldoborrero aldoborrero merged commit f38c8f2 into nix-community:main Oct 5, 2023
44 checks passed
@aldoborrero aldoborrero mentioned this pull request Nov 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aldoborrero aldoborrero Awaiting requested review from aldoborrero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzmitry-lahoda @aldoborrero