Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add defaultText to extraBin.name #336

Merged
merged 1 commit into from
Nov 16, 2023
Merged

fix: add defaultText to extraBin.name #336

merged 1 commit into from
Nov 16, 2023

Conversation

dev-null-undefined
Copy link
Contributor

@dev-null-undefined dev-null-undefined commented Nov 14, 2023 •
edited
Loading

fixes #335

@SuperSandro2000 SuperSandro2000 changed the title fix: fixed missing defaultText #335 Add defaultText to extraBin Nov 15, 2023
@SuperSandro2000 SuperSandro2000 changed the title Add defaultText to extraBin Add defaultText to extraBin.namd Nov 15, 2023
SuperSandro2000
SuperSandro2000 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash merge

@dev-null-undefined
Copy link
Contributor Author

Please squash merge

Done already if not mistaking

@dev-null-undefined
Copy link
Contributor Author

Do you want me to change the commit message?

@nzbr nzbr changed the title Add defaultText to extraBin.namd Add defaultText to extraBin.name Nov 16, 2023
@nzbr nzbr added the bug Something isn't working label Nov 16, 2023
@nzbr nzbr merged commit 83ce0db into nix-community:main Nov 16, 2023
19 checks passed
@nzbr nzbr changed the title Add defaultText to extraBin.name fix: add defaultText to extraBin.name Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@K900 K900 Awaiting requested review from K900

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Evaluation fail
3 participants
@dev-null-undefined @SuperSandro2000 @nzbr