Skip to content

Commit

Permalink
Fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
nivi-apple committed Jul 30, 2024
1 parent 80b8b10 commit 1fa5d26
Show file tree
Hide file tree
Showing 6 changed files with 50 additions and 33 deletions.
1 change: 1 addition & 0 deletions examples/thermostat/thermostat-common/thermostat.matter
Original file line number Diff line number Diff line change
Expand Up @@ -2539,6 +2539,7 @@ endpoint 1 {
ram attribute absMaxHeatSetpointLimit default = 3000;
ram attribute absMinCoolSetpointLimit default = 1600;
ram attribute absMaxCoolSetpointLimit default = 3200;
ram attribute localTemperatureCalibration default = 0x00;
persist attribute occupiedCoolingSetpoint default = 0x0A28;
persist attribute occupiedHeatingSetpoint default = 0x07D0;
ram attribute minHeatSetpointLimit default = 700;
Expand Down
16 changes: 16 additions & 0 deletions examples/thermostat/thermostat-common/thermostat.zap
Original file line number Diff line number Diff line change
Expand Up @@ -4774,6 +4774,22 @@
"maxInterval": 65344,
"reportableChange": 0
},
{
"name": "LocalTemperatureCalibration",
"code": 16,
"mfgCode": null,
"side": "server",
"type": "int8s",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
"bounded": 0,
"defaultValue": "0x00",
"reportable": 1,
"minInterval": 1,
"maxInterval": 65534,
"reportableChange": 0
},
{
"name": "OccupiedCoolingSetpoint",
"code": 17,
Expand Down
50 changes: 25 additions & 25 deletions src/app/tests/suites/certification/Test_TC_TSTAT_4_2.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ tests:
- name: "expectedValue"
value: "y"

- label: "Step 3a: Test Harness writes to the Presets attribute after calling the StartPresetsSchedulesEditRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
- label: "Step 3a: Test Harness writes to the Presets attribute after calling the StartPresetsSchedulesEditRequest command"
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -75,7 +75,7 @@ tests:
- name: "expectedValue"
value: "y"

- label: "Step 3b: Test Harness writes to the Presets attribute adding 3 presets for Sleep, Wake and GoingToSleep"
- label: "Step 3b: Test Harness writes to the Presets attribute adding 3 presets for Sleep, Wake and GoingToSleep"
PICS: TSTAT.S.F08 && TSTAT.S.A0050
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -242,7 +242,7 @@ tests:
value: "y"

- label: "Step 3d: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -323,7 +323,7 @@ tests:
value: "y"

- label: "Step 4a: Test Harness writes to the Presets attribute wherein a built-in preset is removed"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -458,7 +458,7 @@ tests:
value: "y"

- label: "Step 4c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -480,7 +480,7 @@ tests:
value: "y"

- label: "Step 5a: Test Harness writes to the Presets attribute wherein a preset is removed such that its handle matches the active preset handle"
PICS: TSTAT.S.F08 && TSTAT.C.C06.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C06.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -524,7 +524,7 @@ tests:
value: "y"

- label: "Step 5c: Test Harness calls StartPresetsSchedulesEditRequest"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -676,7 +676,7 @@ tests:
value: "y"

- label: "Step 5e: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -698,7 +698,7 @@ tests:
value: "y"

- label: "Step 6a: Test Harness writes to the Presets attribute wherein a built-in preset is modified to a non built-in preset"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -850,7 +850,7 @@ tests:
value: "y"

- label: "Step 6c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -872,7 +872,7 @@ tests:
value: "y"

- label: "Step 7a: Test Harness writes to the Presets attribute wherein a new preset is added with the builtIn flag set to true"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -1024,7 +1024,7 @@ tests:
value: "y"

- label: "Step 7c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -1046,7 +1046,7 @@ tests:
value: "y"

- label: "Step 8a: Test Harness writes to the Presets attribute with a preset having a non-null preset handle that doesn't exist in the Presets attribute"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -1198,7 +1198,7 @@ tests:
value: "y"

- label: "Step 8c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -1219,7 +1219,7 @@ tests:
value: "y"

- label: "Step 9a: Test Harness writes to the Presets attribute wherein there are 2 presets with the same preset handle"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -1371,7 +1371,7 @@ tests:
value: "y"

- label: "Step 9c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -1392,7 +1392,7 @@ tests:
value: "y"

- label: "Step 10a: Test Harness writes to the Presets attribute wherein a built-in preset is modified to be a non built-in preset"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -1544,7 +1544,7 @@ tests:
value: "y"

- label: "Step 10c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -1566,7 +1566,7 @@ tests:
value: "y"

- label: "Step 11a: Test Harness writes to the Presets attribute wherein a non built-in preset is modified to a built-in preset"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -1718,7 +1718,7 @@ tests:
value: "y"

- label: "Step 11c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -1740,7 +1740,7 @@ tests:


- label: "Step 12a: Test Harness writes to the Presets attribute wherein a preset doesn't support names in the PresetTypeFeatures bitmap but has a name in the write presets command"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -1892,7 +1892,7 @@ tests:
value: "y"

- label: "Step 12c: Test Harness calls the CommitPresetsSchedulesRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C09.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C09.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand All @@ -1915,7 +1915,7 @@ tests:
#TODO: Add tests for the total number of Presets exceeds the NumberOfPresets supported. Also Add tests for adding presets with preset scenario not present in PresetTypes.

- label: "Step 13a: Test Harness writes to the Presets attribute but calls CancelPresetsSchedulesEditRequest command to cancel the edit request"
PICS: TSTAT.S.F08 && TSTAT.C.C07.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C07.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down Expand Up @@ -2068,7 +2068,7 @@ tests:
value: "y"

- label: "Step 13c: Test Harness calls the CancelPresetsSchedulesEditRequest command"
PICS: TSTAT.S.F08 && TSTAT.C.C08.Tx
PICS: TSTAT.S.F08 && TSTAT.S.C08.Rsp
verification: |
Optional Attribute - If it is supported, then in TH log it will results in displaying the value, else it will display UNSUPPORTED_ATTRIBUTE. Below is the log of RPI the result may be vary on the basis of dut implementation.
Expand Down
8 changes: 4 additions & 4 deletions src/darwin/Framework/CHIP/zap-generated/MTRBaseClusters.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/darwin/Framework/CHIP/zap-generated/MTRStructsObjc.mm

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1fa5d26

Please sign in to comment.