fix(svgo): correctly pick up options from external config file

nivekcode · Jun 4, 2020 · 9b8d138 · 9b8d138
1 parent 4a2cf39
commit 9b8d138
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 8 deletions.
diff --git a/src/lib/converters/multiple-files.converter.ts b/src/lib/converters/multiple-files.converter.ts
@@ -33,8 +33,6 @@ const writeFiles = async (outputDirectory, iconsFolderName, modelFileName, prefi
 
 export const convertToMultipleFiles = async (convertionOptions: MultiFileConvertionOptions): Promise<void> => {
   const {
-    typeName,
-    interfaceName,
     prefix,
     outputDirectory,
     modelFileName,

diff --git a/src/lib/helpers/file-helpers.ts b/src/lib/helpers/file-helpers.ts
@@ -20,7 +20,7 @@ export const writeFile = async (outputDirectory: string, fileName: string, fileC
   await writeFileToFS(path.join(outputDirectory, `${fileName}.ts`), formatedFileContent);
 };
 
-export const readFile = async (filePath: string): Promise<any> => {
+export const readFile = async (filePath: string): Promise<string> => {
   return readfileFromFS(filePath, 'utf-8');
 };
 

diff --git a/src/lib/helpers/svg-optimization.ts b/src/lib/helpers/svg-optimization.ts
@@ -6,7 +6,7 @@ export const generateSvgOptimizer = config => new svgo(config);
 
 export const getSvgoConfig = async (svgoConfig: any): Promise<string> => {
   if (typeof svgoConfig === 'string') {
-    return readFile(svgoConfig);
+    return JSON.parse(await readFile(svgoConfig));
   }
   return svgoConfig;
 };
diff --git a/svgo-test.config.json b/svgo-test.config.json
@@ -1,10 +1,7 @@
 {
   "plugins": [
     {
-      "cleanupAttrs": true
-    },
-    {
-      "removeDoctype": true
+      "removeViewBox": false
     }
   ]
 }