Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add workspaceDir and use it for presets auto generated dir #481

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

resolves #149

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This is an initial implementation of workspaceDir and migrating presets that have 'magic folders' (vercel, netlify + stormkit) to use this.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the enhancement New feature or request label Sep 7, 2022
@danielroe danielroe requested a review from pi0 September 7, 2022 12:18
@danielroe danielroe self-assigned this Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #481 (58e2d60) into main (c902104) will decrease coverage by 0.05%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main     #481      +/-   ##
==========================================
- Coverage   63.34%   63.29%   -0.06%     
==========================================
  Files          54       54              
  Lines        3615     3618       +3     
  Branches      381      380       -1     
==========================================
  Hits         2290     2290              
- Misses       1314     1316       +2     
- Partials       11       12       +1     
Impacted Files Coverage Ξ”
src/types/nitro.ts 100.00% <ΓΈ> (ΓΈ)
src/presets/netlify.ts 24.41% <25.00%> (ΓΈ)
src/options.ts 49.32% <33.33%> (-0.68%) ⬇️
src/presets/vercel.ts 77.47% <50.00%> (ΓΈ)
src/presets/stormkit.ts 100.00% <100.00%> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pi0 pi0 changed the title feat: add workspaceDir feat: add workspaceDir and use it for presets auto generated dir Sep 7, 2022
@pi0 pi0 merged commit 11cc5cd into main Sep 7, 2022
@pi0 pi0 deleted the feat/workspace-dir branch September 7, 2022 13:27
WinterYukky pushed a commit to WinterYukky/nitro that referenced this pull request Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workspaceDir option
2 participants