Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(raw): avoid extra this.resolve when possible #2857

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

Aareksio
Copy link
Contributor

@Aareksio Aareksio commented Nov 7, 2024

Resolves #2856

πŸ”— Linked issue

#2856

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

As discussed in linked issue.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Aareksio Aareksio requested a review from pi0 as a code owner November 7, 2024 19:01
@Aareksio Aareksio changed the title fix(plugin-raw): do not resolve id unless extname is explicitly allowed fix(plugin-raw): resolve id only for allowed extnames Nov 7, 2024
@pi0 pi0 changed the title fix(plugin-raw): resolve id only for allowed extnames perf(raw): resolve id only for allowed extnames Nov 7, 2024
@pi0
Copy link
Member

pi0 commented Nov 7, 2024

Added tests (03bdd2d) this does not break #2838, #2836 but only with early return avoiding extra this.resolve call (which is really strange and we should later investigate root cause of this amount of overhead)

@pi0 pi0 changed the title perf(raw): resolve id only for allowed extnames perf(raw): avoid extra this.resolve when possible Nov 7, 2024
@pi0 pi0 merged commit 28bdfbb into nitrojs:v2 Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build time regression in 2.10.1
2 participants