Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scan env specific handlers without method in their name #2852

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

sandros94
Copy link
Contributor

πŸ”— Linked issue

Resolves #2850

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Switching to named capture groups within the regex both simplifies the maintenance of its implementation as well as directly creates a binding between the regex's named groups and the related method and env variables.

P.S.: having troubles with my dev machine, didn't run pnpm dev/pnpm test, but it is such a small fix (famous last words).

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 requested a review from pi0 as a code owner November 5, 2024 17:56
@pi0 pi0 changed the title fix: environment specific event handlers fix: scan env specific handlers without method in their name Nov 5, 2024
@pi0 pi0 merged commit 0409601 into nitrojs:v2 Nov 5, 2024
4 checks passed
@sandros94 sandros94 deleted the fix-route-env-suffix branch November 5, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

environment specific event handlers only work when method is also specified
2 participants