Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: load presets from unbundled nitropack/presets #2459

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented May 21, 2024

Resolves #2448

This PR moves internal resolvePreset under nitropack/presets which is unpacked dist and resolves to correct entries.

As a hotfix, a small change added to rollup config to make sure always entry's parent (usually preset's /runtime) is bundled.

@pi0 pi0 merged commit 943f11e into main May 21, 2024
4 of 5 checks passed
@pi0 pi0 deleted the build/presets branch May 21, 2024 17:45
@pi0 pi0 mentioned this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nightly] Could not resolve entry module "node_modules/nitropack/dist/chunks/runtime/node-server"
1 participant