Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for environment variables and runtime config overrides #1549

Merged
merged 23 commits into from
Aug 20, 2023

Conversation

Hebilicious
Copy link
Contributor

@Hebilicious Hebilicious commented Aug 7, 2023

πŸ”— Linked issue

Extracted from #1318

closes #1150

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

While working on #1318 , I realised it was better to extract the tests from this PR into a standalone PR, as they can now be used to test useRuntimeConfig with every presets.
I noticed a bug in the cloudflare preset as well that I included here, however I can include it in another PR if that's better.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious changed the title test/load env variable test: load environment variable with useRuntimeConfig Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Merging #1549 (2d71fb9) into main (e35e6b2) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
- Coverage   76.54%   76.45%   -0.10%     
==========================================
  Files          76       76              
  Lines        7773     7773              
  Branches      783      781       -2     
==========================================
- Hits         5950     5943       -7     
- Misses       1821     1827       +6     
- Partials        2        3       +1     

see 2 files with indirect coverage changes

@pi0 pi0 changed the title test: load environment variable with useRuntimeConfig test: add tests for environment variables and runtime config overrides Aug 20, 2023
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit a04c663 into main Aug 20, 2023
@pi0 pi0 deleted the test/load-env-variable branch August 20, 2023 22:39
@pi0 pi0 mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests for process.env support
2 participants