-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for environment variables and runtime config overrides #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hebilicious
changed the title
test/load env variable
test: load environment variable with useRuntimeConfig
Aug 7, 2023
7 tasks
Hebilicious
commented
Aug 7, 2023
Codecov Report
@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
- Coverage 76.54% 76.45% -0.10%
==========================================
Files 76 76
Lines 7773 7773
Branches 783 781 -2
==========================================
- Hits 5950 5943 -7
- Misses 1821 1827 +6
- Partials 2 3 +1 |
pi0
changed the title
test: load environment variable with useRuntimeConfig
test: add tests for environment variables and runtime config overrides
Aug 20, 2023
pi0
approved these changes
Aug 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
Extracted from #1318
closes #1150
β Type of change
π Description
While working on #1318 , I realised it was better to extract the tests from this PR into a standalone PR, as they can now be used to test
useRuntimeConfig
with every presets.I noticed a bug in the
cloudflare
preset as well that I included here, however I can include it in another PR if that's better.π Checklist