fix(cloudflare-pages): remove .html extension from _routes.json (#…

…2498)
nitrojs · Jun 7, 2024 · 79b85fe · 79b85fe
1 parent 0112801
commit 79b85fe
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 8 deletions.
diff --git a/package.json b/package.json
@@ -70,11 +70,7 @@
     "nitro": "./dist/cli/index.mjs",
     "nitropack": "./dist/cli/index.mjs"
   },
-  "files": [
-    "dist",
-    "*.d.ts",
-    "runtime-meta.*"
-  ],
+  "files": ["dist", "*.d.ts", "runtime-meta.*"],
   "scripts": {
     "build": "pnpm gen-presets && unbuild",
     "dev": "pnpm nitro dev playground",

diff --git a/src/presets/cloudflare/utils.ts b/src/presets/cloudflare/utils.ts
@@ -84,8 +84,16 @@ async function writeCFRoutes(nitro: Nitro) {
       ),
     ],
   });
+  // Remove index.html or the .html extension to support pages pre-rendering
   routes.exclude!.push(
-    ...publicAssetFiles.map((i) => withLeadingSlash(i)).sort(comparePaths)
+    ...publicAssetFiles
+      .map(
+        (i) =>
+          withLeadingSlash(i)
+            .replace(/\/index\.html$/, "")
+            .replace(/\.html$/, "") || "/"
+      )
+      .sort(comparePaths)
   );
 
   // Only allow 100 rules in total (include + exclude)

diff --git a/test/presets/cloudflare-pages.test.ts b/test/presets/cloudflare-pages.test.ts
@@ -44,11 +44,11 @@ describe.skipIf(isWindows)("nitro:preset:cloudflare-pages", async () => {
           "/_unignored.txt",
           "/favicon.ico",
           "/json-string",
+          "/prerender",
           "/api/hello",
-          "/prerender/index.html",
+          "/api/hey",
           "/prerender/index.html.br",
           "/prerender/index.html.gz",
-          "/api/hey/index.html",
           "/api/param/foo.json",
           "/api/param/hidden",
           "/api/param/prerender1",