Added VmSlice class, a slice in the virtual address space. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-nitro
changed the title
|
Wondering if I should add back Iter (etc), even if we don't currently require it, since this is a slice class and should really have it for completeness. |
comment tweak Co-authored-by: Petar Vujović <[email protected]>
…ented one use of it (out of six)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add a new VmSlice class, to support slices that are in VM-space. This is needed for keys (or anything else) that are implemented as slices-of-slices. The "inner" slice is in VM-space, but the existing code treats it as if it were a physical address by using a "real" Rust slice for it. This works okay as long as the Agave code is compiled with 64-bit addresses, which matches the 64-bit VM address space. However, if the code is built in 32 bits, interpreted programs can fail with bad memory accesses.
Summary of Changes
Addition of VmSlice class: a virtual-space slice.
Fixes #