Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: graalvm support for nitrite-mvstore-adapter #995

Merged
merged 6 commits into from
Jul 9, 2024

Conversation

DarkAtra
Copy link
Contributor

@DarkAtra DarkAtra commented Jul 6, 2024

Fixes: #403

Note: this PR does not make nitrite fully native compatible as i did not test all codepaths. To be tested:

Already tested via nitrite-native-tests:

  • creating and opening a database with user credentials
  • reading and writing to the database using ObjectRepository (mvstore adapter)
  • reading and writing to the database using NitriteCollection (mvstore adapter)
  • creating indices and filtering by an indexed field (mvstore adapter)
  • simple Transactions (commit and rollback)
  • Schema Migrations

@DarkAtra DarkAtra changed the title feat: graalvm support for mvstore feat: graalvm support for nitrite-mvstore-adapter Jul 6, 2024
@anidotnet
Copy link
Contributor

@DarkAtra thanks a lot for the PR. Are you planning to complete the To be tested: items also? Please include rocksdb-adapter in your To be tested: list.

@DarkAtra
Copy link
Contributor Author

DarkAtra commented Jul 8, 2024

@DarkAtra thanks a lot for the PR. Are you planning to complete the To be tested: items also? Please include rocksdb-adapter in your To be tested: list.

I don't think that i'm going to complete all items on the todo list as it's quite a lot of work. However, with this PR, it should be easier to add and test native hints for remaining modules in the future. It might also help to migrate all existing tests to JUnit 5 first and then continue with GraalVM compatibility as this would allow reusing them.

@anidotnet anidotnet merged commit f2338fd into nitrite:main Jul 9, 2024
16 checks passed
@DarkAtra DarkAtra deleted the feat/graalvm-support-for-mvstore branch August 10, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with GraalVM
2 participants