Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/url download #99

Merged
merged 1 commit into from
May 3, 2023
Merged

Fix/url download #99

merged 1 commit into from
May 3, 2023

Conversation

raksiv
Copy link
Member

@raksiv raksiv commented May 2, 2023

No description provided.

@raksiv raksiv added the bug Something isn't working label May 2, 2023
@raksiv raksiv self-assigned this May 2, 2023
@raksiv raksiv force-pushed the fix/url-download branch from 1c7eda5 to af9fc32 Compare May 2, 2023 17:43
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: -4.27 ⚠️

Comparison is base (d6e19d6) 71.91% compared to head (af9fc32) 67.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #99      +/-   ##
===========================================
- Coverage    71.91%   67.65%   -4.27%     
===========================================
  Files           32       33       +1     
  Lines         2300     2470     +170     
===========================================
+ Hits          1654     1671      +17     
- Misses         646      799     +153     
Impacted Files Coverage Δ
nitric/api/storage.py 89.06% <ø> (ø)
nitric/application.py 50.94% <ø> (-8.44%) ⬇️
nitric/faas.py 81.07% <ø> (+0.04%) ⬆️
nitric/proto/nitric/deploy/v1/__init__.py 0.00% <ø> (ø)
nitric/proto/nitric/faas/v1/__init__.py 91.12% <ø> (+0.29%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HomelessDinosaur HomelessDinosaur merged commit 34429b8 into develop May 3, 2023
@HomelessDinosaur HomelessDinosaur deleted the fix/url-download branch May 3, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants