Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http response handling #53

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Fix http response handling #53

merged 1 commit into from
Oct 27, 2021

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented Oct 27, 2021

Fixes for response handling with headers and a synthetic setter for string/bytes responses for http.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #53 (adab42c) into develop (3b3e8b3) will increase coverage by 0.05%.
The diff coverage is 92.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #53      +/-   ##
===========================================
+ Coverage    95.98%   96.04%   +0.05%     
===========================================
  Files           13       13              
  Lines          748      759      +11     
===========================================
+ Hits           718      729      +11     
  Misses          30       30              
Impacted Files Coverage Δ
nitric/faas.py 88.38% <92.30%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3e8b3...adab42c. Read the comment docs.

@jyecusch jyecusch merged commit 941efa2 into develop Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants