Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add secrets service support #31

Merged
merged 1 commit into from
Aug 9, 2021
Merged

feat: add secrets service support #31

merged 1 commit into from
Aug 9, 2021

Conversation

jyecusch
Copy link
Member

@jyecusch jyecusch commented Aug 9, 2021

Closes: #29

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #31 (f3c6f04) into main (4aeca36) will increase coverage by 0.60%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
+ Coverage   93.25%   93.85%   +0.60%     
==========================================
  Files          15       16       +1     
  Lines         563      618      +55     
==========================================
+ Hits          525      580      +55     
  Misses         38       38              
Impacted Files Coverage Δ
nitric/api/__init__.py 100.00% <100.00%> (ø)
nitric/api/secrets.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aeca36...f3c6f04. Read the comment docs.

Copy link
Member

@tjholm tjholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tjholm tjholm merged commit e00edc4 into main Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Secret - Add Secret Service Support
3 participants