Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update tests and fix api path bug #105

Merged
merged 3 commits into from
May 8, 2023
Merged

Conversation

HomelessDinosaur
Copy link
Member

@HomelessDinosaur HomelessDinosaur commented May 5, 2023

68% coverage -> 95%

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +26.94 🎉

Comparison is base (7f04d24) 67.63% compared to head (4e17012) 94.57%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #105       +/-   ##
============================================
+ Coverage    67.63%   94.57%   +26.94%     
============================================
  Files           33       23       -10     
  Lines         2472     1365     -1107     
============================================
- Hits          1672     1291      -381     
+ Misses         800       74      -726     
Impacted Files Coverage Δ
nitric/api/storage.py 95.45% <100.00%> (+6.39%) ⬆️
nitric/application.py 100.00% <100.00%> (+49.05%) ⬆️
nitric/faas.py 85.15% <100.00%> (+4.08%) ⬆️
nitric/resources/apis.py 100.00% <100.00%> (+58.04%) ⬆️
nitric/resources/buckets.py 94.28% <100.00%> (ø)
nitric/resources/schedules.py 96.77% <100.00%> (+63.44%) ⬆️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HomelessDinosaur HomelessDinosaur merged commit c31870d into develop May 8, 2023
@HomelessDinosaur HomelessDinosaur deleted the feat/update-tests branch May 8, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants