fix(aws): improve the error if an undefined service is declared in APIs #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #706 +/- ##
==========================================
- Coverage 48.91% 48.88% -0.03%
==========================================
Files 28 28
Lines 3549 3549
==========================================
- Hits 1736 1735 -1
Misses 1695 1695
- Partials 118 119 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tjholm
approved these changes
Dec 9, 2024
raksiv
reviewed
Dec 9, 2024
davemooreuws
approved these changes
Dec 9, 2024
jyecusch
force-pushed
the
fix/undefined-service-errors
branch
from
1fff737 to
5f31dbd
Compare
jyecusch
force-pushed
the
fix/undefined-service-errors
branch
from
5f31dbd to
fadbbf9
Compare
|
🎉 This PR is included in version 1.16.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error can't occur with standard nitric providers, but catching it helps with custom providers that may edit the API spec before generating the AWS specific spec.
Currently this panics with a invalid memory address or nil pointer dereference error message, which makes it unclear what went wrong.