Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure GCP gateway timeouts match target service timeout. #617

Merged
merged 3 commits into from
May 30, 2024

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented May 23, 2024

No description provided.

@tjholm tjholm marked this pull request as ready for review May 23, 2024 04:04
@tjholm tjholm requested a review from jyecusch as a code owner May 23, 2024 04:04
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.22%. Comparing base (811df85) to head (b82f1f9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   49.19%   49.22%   +0.03%     
==========================================
  Files          23       23              
  Lines        3232     3232              
==========================================
+ Hits         1590     1591       +1     
  Misses       1537     1537              
+ Partials      105      104       -1     
Flag Coverage Δ
aws 43.82% <ø> (+0.07%) ⬆️
azure 53.29% <ø> (ø)
core 77.77% <ø> (ø)
gcp 47.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjholm tjholm force-pushed the gcp-api-gateway-timeout branch from 3f91b59 to 11ea152 Compare May 23, 2024 21:52
@tjholm tjholm requested a review from raksiv May 23, 2024 23:58
Copy link
Member

@jyecusch jyecusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions, not critical

cloud/common/deploy/image/image.go Show resolved Hide resolved
cloud/gcp/deploy/api.go Outdated Show resolved Hide resolved
@tjholm tjholm force-pushed the gcp-api-gateway-timeout branch from 11ea152 to 631d5a0 Compare May 29, 2024 00:12
@tjholm tjholm merged commit f74db93 into main May 30, 2024
4 checks passed
@tjholm tjholm deleted the gcp-api-gateway-timeout branch May 30, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants