Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert aws image uri changes. #596

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: revert aws image uri changes. #596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d0b1c5d
revert aws image uri changes.
tjholm Mar 5, 2024
6bde133
Add follow on note on reversion.
tjholm Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cloud/aws/deploy/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,9 @@ func (a *NitricAwsPulumiProvider) Service(ctx *pulumi.Context, parent pulumi.Res
a.lambdas[name], err = awslambda.NewFunction(ctx, name, &awslambda.FunctionArgs{
// Use repository to generate the URI, instead of the image, using the image results in errors when the same project is torn down and redeployed.
// This appears to be because the local image ends up with multiple repositories and the wrong one is selected.
ImageUri: pulumi.Sprintf("%s:latest", repo.RepositoryUrl),
// XXX: Reverted change for the above comment as lambda image deployments were not rolling forward (under tag latest)
// causing intermittent deployment and runtime failures
ImageUri: image.URI(),
MemorySize: pulumi.IntPtr(typeConfig.Lambda.Memory),
Timeout: pulumi.IntPtr(typeConfig.Lambda.Timeout),
PackageType: pulumi.String("Image"),
Expand Down
Loading