Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AWS websocket support #459

Merged
merged 4 commits into from
Jul 10, 2023
Merged

feat: AWS websocket support #459

merged 4 commits into from
Jul 10, 2023

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented May 31, 2023

Add support for websockets to AWS.

@tjholm tjholm force-pushed the websockets-aws branch 3 times, most recently from 31584f2 to 980f133 Compare June 6, 2023 02:16
@tjholm tjholm marked this pull request as ready for review July 6, 2023 02:44
@tjholm tjholm requested a review from jyecusch as a code owner July 6, 2023 02:44
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch coverage: 56.56% and project coverage change: -0.03 ⚠️

Comparison is base (6b2fa80) 56.09% compared to head (5f4d2c1) 56.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
- Coverage    56.09%   56.06%   -0.03%     
===========================================
  Files           50       50              
  Lines         4799     4880      +81     
===========================================
+ Hits          2692     2736      +44     
- Misses        1913     1944      +31     
- Partials       194      200       +6     
Flag Coverage Δ
aws 55.79% <55.69%> (+0.14%) ⬆️
azure 60.80% <ø> (ø)
core 61.22% <60.00%> (-0.20%) ⬇️
gcp 42.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cloud/aws/runtime/core/provider.go 38.06% <0.00%> (-1.81%) ⬇️
core/pkg/plugins/resource/plugin.go 0.00% <ø> (ø)
core/pkg/adapters/grpc/resources_grpc.go 74.64% <60.00%> (-7.62%) ⬇️
cloud/aws/runtime/gateway/lambda.go 53.50% <61.22%> (+1.05%) ⬆️
cloud/aws/runtime/gateway/event.go 62.30% <82.35%> (+2.65%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tjholm tjholm merged commit f8ccb10 into develop Jul 10, 2023
@tjholm tjholm deleted the websockets-aws branch July 10, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants