Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws): allow existing secret import #449

Merged
merged 4 commits into from
May 25, 2023
Merged

Conversation

tjholm
Copy link
Member

@tjholm tjholm commented May 24, 2023

Example config

name: test-aws
provider: nitric/[email protected]
region: ap-southeast-2
import:
  secrets:
    test: <your_secrets_arn>

Behaviours:

  • If you add an import over an existing nitric secret, that secret will be deleted and replaced by the imported secret.
  • If you remove an imported secret that secret will not be deleted, but a new nitric secret will be created to take its place.
  • Imported secrets will be tagged as part of the deployment process. With essential nitric tags
  • If an imported secret cannot be located, deployment will fail.

@tjholm tjholm requested a review from jyecusch May 24, 2023 07:12
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (75404c6) 53.66% compared to head (3f8c58d) 53.66%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #449   +/-   ##
========================================
  Coverage    53.66%   53.66%           
========================================
  Files           25       25           
  Lines         1692     1692           
========================================
  Hits           908      908           
  Misses         708      708           
  Partials        76       76           
Flag Coverage Δ
unittests 53.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jyecusch jyecusch changed the title feat: Allow existing secret import feat(aws): allow existing secret import May 24, 2023
@tjholm tjholm merged commit e85e646 into develop May 25, 2023
@tjholm tjholm deleted the fix/update-dependencies branch May 25, 2023 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants