Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add trace context to both http and event requests #72

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

asalkeld
Copy link
Contributor

@asalkeld asalkeld commented Nov 15, 2022

This needs the membrane change nitrictech/nitric#350 in (to get the required contracts).

@asalkeld asalkeld force-pushed the feat-add-trace-context branch from 2a67934 to 6512b6b Compare November 22, 2022 04:11
@asalkeld asalkeld force-pushed the feat-add-trace-context branch from a58426b to 034d307 Compare November 24, 2022 06:07
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Base: 77.11% // Head: 75.19% // Decreases project coverage by -1.92% ⚠️

Coverage data is based on head (034d307) compared to base (315181d).
Patch coverage: 47.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
- Coverage    77.11%   75.19%   -1.93%     
===========================================
  Files           39       40       +1     
  Lines         1748     1830      +82     
===========================================
+ Hits          1348     1376      +28     
- Misses         340      390      +50     
- Partials        60       64       +4     
Flag Coverage Δ
unittests 75.19% <47.50%> (-1.93%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
faas/request.go 60.86% <0.00%> (-26.64%) ⬇️
resources/common.go 100.00% <ø> (ø)
resources/trace.go 0.00% <0.00%> (ø)
resources/manager.go 36.76% <7.69%> (+2.21%) ⬆️
resources/api.go 77.14% <61.29%> (-3.42%) ⬇️
api/storage/file.go 92.85% <66.66%> (ø)
faas/context.go 89.81% <70.00%> (-2.35%) ⬇️
api/documents/document_ref.go 72.36% <100.00%> (ø)
api/documents/query.go 95.18% <100.00%> (ø)
api/events/topic.go 64.70% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tjholm tjholm merged commit d126bb2 into develop Nov 24, 2022
@tjholm tjholm deleted the feat-add-trace-context branch November 24, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants