Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort topic names before print to CLI output #569

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Conversation

jyecusch
Copy link
Member

@jyecusch jyecusch commented Aug 24, 2023

Fixes the issue raised here: nitrictech/nitric#499

New output:

Cursor_and_topics_ts_—_topic-list-test

pkg/run/stack.go Outdated Show resolved Hide resolved
@jyecusch jyecusch force-pushed the fix/print-sorted-topics branch from 20940bb to 2be3d17 Compare August 24, 2023 01:42
@jyecusch jyecusch requested a review from tjholm August 24, 2023 01:43
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1be0f5a) 25.87% compared to head (4237df2) 25.87%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #569   +/-   ##
========================================
  Coverage    25.87%   25.87%           
========================================
  Files           28       28           
  Lines         1932     1932           
========================================
  Hits           500      500           
  Misses        1402     1402           
  Partials        30       30           
Flag Coverage Δ
unittests 25.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tjholm tjholm merged commit 4c9f7ef into develop Aug 24, 2023
@jyecusch jyecusch changed the title sorted topic names before print to CLI output sort topic names before print to CLI output Aug 24, 2023
@nitric-bot
Copy link
Contributor

🎉 This PR is included in version 1.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants