Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve navigation bar handling #80

Merged
merged 2 commits into from
Feb 11, 2015
Merged

Improve navigation bar handling #80

merged 2 commits into from
Feb 11, 2015

Conversation

h6ah4i
Copy link
Contributor

@h6ah4i h6ah4i commented Feb 9, 2015

This pull request fixes the issue #45.

  • Automatically handles navigation bar visibility changes, and fully compatible with both software key and hardware key devices.
  • Added an Immersive mode sample to check navigation bar handling.

Tested on these devices;

  • Nexus 5 (Phone / Lollipop)
  • Nexus 9 (Tablet / Lollipop)
  • Galaxy S4 (Phone / KitKat / Hardware key)
  • Ployer momo9 (Tablet / JB MR1)
  • Galaxy S2 (Phone / ICS / Hardware key)
  • Motorola Photon 4G (Phone / Gingerbread / Hardware key)

@h6ah4i h6ah4i force-pushed the feature/improve_navbar_handling branch from d4fd058 to 9f5a324 Compare February 9, 2015 14:46
wmora added a commit that referenced this pull request Feb 11, 2015
@wmora
Merge pull request #80 from h6ah4i/feature/improve_navbar_handling
1ba38c1 
Improve navigation bar handling
@wmora wmora merged commit 1ba38c1 into nispok:master Feb 11, 2015
@wmora wmora added this to the 2.9.0 milestone Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@h6ah4i @wmora