Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tablet layout as defined in Material Design spec. #7

Merged
merged 1 commit into from
Oct 4, 2014

Conversation

ashughes
Copy link
Contributor

No description provided.

@wmora
Copy link
Contributor

wmora commented Sep 24, 2014

@ashughes is this done or are you still working on it?

@ashughes
Copy link
Contributor Author

This should be done. Do you see any issues with it?

The Material Design spec is a little ambiguous about how the Snackbar should behave when the message text causes it to be between the defined min and max width. I decided to go with wrap_content while maintaining the min and max width for the Snackbar and keeping 48dp padding between the message text and the action button. I tested this with various sized message texts on a tablet and I think it looks good.

If the spec becomes more clear in the final draft, we can update the behavior.

@wmora
Copy link
Contributor

wmora commented Sep 24, 2014

I haven't checked it yet, I was just asking. I'll probably take a look at it tomorrow.

@wmora wmora merged commit ab5d0b8 into nispok:master Oct 4, 2014
@wmora
Copy link
Contributor

wmora commented Oct 31, 2014

@ashughes have you seen Inbox? The snackbar they use does not "float" on tablets as stated in the specs. It slides from the bottom as it is a phone. Why Google!? Why!?

@wmora wmora mentioned this pull request Nov 21, 2014
@ashughes ashughes deleted the feature/tablet_layout branch December 6, 2014 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants