added min_width max_width to default values.xml #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a crash when calling SnackbarManager.show(snackbar,false) on devices where the smallest width is less than 600dp, such as the nexus 5. It would throw a resource not found exception because the only value specified for the resource is in values-sw600dp Particularly, it would crash on line layout.setMinimumWidth(res.getDimensionPixelSize(dimen.sb__min_width)); in private MarginLayoutParams init(Context context, Activity targetActivity, ViewGroup parent, boolean usePhoneLayout) of snackbar.java because it's being forced to use the tablet specific implementation when it would normally do so, namely when the width is less than 600dp on a device like the nexus 5 which is 360.0 dp x 592.0 dp
wmora
added a commit
that referenced
this pull request
May 30, 2015
added min_width max_width to default values.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a crash when calling
SnackbarManager.show(snackbar,false) on devices where the smallest width is less than 600dp, such as the nexus 5. It would throw a resource not found exception because the only value specified for the resource is in values-sw600dp
Particularly, it would crash on line layout.setMinimumWidth(res.getDimensionPixelSize(dimen.sb__min_width)); in
private MarginLayoutParams init(Context context, Activity targetActivity, ViewGroup parent, boolean usePhoneLayout)
of snackbar.java because it's being forced to use the tablet specific implementation when it would not normally do so, namely when the width is less than 600dp on a device like the nexus 5 which is 360.0 dp x 592.0 dp