Decision module may access available interventions #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added two layers of set operations in the DecisionManager and DecisionModule
Consider set of all interventions $I$
Set of planned interventions $P \subset I$
Available interventions $A = P \cap I$
Decisions at time t $D_t \subset A - D_{t-1}$
Codecov Report
@@ Coverage Diff @@
## develop #339 +/- ##
===========================================
+ Coverage 70.43% 70.57% +0.13%
===========================================
Files 59 59
Lines 5135 5179 +44
Branches 608 615 +7
===========================================
+ Hits 3617 3655 +38
- Misses 1426 1431 +5
- Partials 92 93 +1
Continue to review full report at Codecov.
|
1 task
There was a problem hiding this comment.
Looks good 👍 - neat simplification of pre-specified planning, clear processing for the planned/decided/retired sets.
I've suggested a couple of minor changes in comments.
Could we use some of the PR comment/docstrings content to start a doc page (after 'Adding a Model') while this is fresh?
- Consider set of all interventions
- Set of planned interventions
- Available interventions
- Decisions at time t
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two layers of set operations in the DecisionManager and DecisionModule and addresses issue #333. DecisionManager now updates pre-decision state (from the previous iteration) with new decisions and writes this to the store for current timestep and iteration.
This is a requirement of nismod/nismod2#82
Consider set of all interventions
Set of planned interventions
Available interventions
Decisions at time t
Todo:
This PR now also removes the pre-specified planning decision module, instead treating initial conditions and pre-specified planning as state which is all dealt with in the
get_and_save_decisionsmethod in the decision manager.