Update digital comms wrapper #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwardoughton - I've got to leave this now for the morning. Perhaps you could have a look at what I've done so far? Next step is to move onto defining the inputs and outputs of the digital comms model, with the understanding that all the interventions will be supplied by the decision module. |
- Simplified wrapper by moving all of the decision logic into a newly created decisions module - Currently blocked by need to import adoption scenario data into decisions module - Need to better understand dimensionality of technology and distribution points and work out how to pass these as interventions (if appropriate) to the decision module
|
@edwardoughton and @tomalrussell - now got to the point where we need to think through i) how to get the right data into the decision module ii) how we should package up digital comms "interventions". |
tomalrussell
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step towards completing #53
Requires nismod2/digital_comms#80 as
run.pyuses various utility functions fromrunner.pyprocessed_data.zipfrom FTP serverWith the command
smif run digital_comms_testI successfully read in the parameters fromdefaults.csvbefore_model_runruns successfullyNetworkManagerobjectData
The data package needs to contain the scenario files that are removed from the NISMOD2 repo in this PR. (
data/scenarios/*_adoption.csv)