Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NDEV-19285-convert-rbac-best-practices-to-cel-policies #140

Merged
merged 22 commits into from
Jun 18, 2024
Merged

feat: NDEV-19285-convert-rbac-best-practices-to-cel-policies #140

merged 22 commits into from
Jun 18, 2024

Conversation

Chandan-DK
Copy link
Contributor

This PR includes the following:

  • Conversions of rbac-best-practices policies to CEL.
  • Tests for VAPs generated by the CEL policies

Chandan-DK and others added 19 commits June 7, 2024 09:23
@Chandan-DK
NDEV-19285 copy restrict-binding-system-groups
b889a51 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 convert restrict-binding-system-groups
d67c88e 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 copy restrict-clusterrole-nodesproxy
0269a63 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 convert restrict-clusterrole-nodesproxy
42107d6 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 test edge cases for restrict-clusterrole-nodesproxy
4a3ec67 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 copy restrict-escalation-verbs-roles
42149b4 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 add case where rules is null in restrict-clusterrole-nodes…
d8d50be 
…proxy

Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 convert restrict-escalation-verbs-roles
f009ec0 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 test edge cases for restrict-escalation-verbs-roles
9057260 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 copy restrict-wildcard-resources
7de6a90 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 convert restrict-wildcard-resources
2ed34b7 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 rename roles and add extra cases for restrict-wildcard-res…
c012a2c 
…ources

Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 rename roles for clarity
b8b7029 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 add vap tests for restrict-binding-system-groups
1538c24 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 add vap tests for restrict-clusterrole-nodesproxy
393d182 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 add vap tests for restrict-escalation-verbs-roles
36613f6 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 add vap tests for restrict-wildcard-resources
80fbb52 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
NDEV-19285 add vap tests in workflow
1e3a8fc 
Signed-off-by: Chandan-DK <[email protected]>
@Chandan-DK
Merge branch 'main' into NDEV-19285-convert-rbac-best-practices-to-ce…
3543cfa 
…l-policies
@Chandan-DK
Copy link
Contributor Author

Chandan-DK commented Jun 7, 2024 •
edited
Loading

Tests for CEL policies fail in n4k version 3.0.29 because CEL wasn't introduced in kyverno policies. Unsure about the next steps to take in resolving this issue.

nsathyaseelan
nsathyaseelan approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@nsathyaseelan nsathyaseelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anusha94 anusha94 merged commit 090cf09 into main Jun 18, 2024
15 checks passed
@Chandan-DK Chandan-DK deleted the NDEV-19285-convert-rbac-best-practices-to-cel-policies branch June 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsathyaseelan nsathyaseelan nsathyaseelan approved these changes

@anusha94 anusha94 Awaiting requested review from anusha94

@anushkamittal2001 anushkamittal2001 Awaiting requested review from anushkamittal2001

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chandan-DK @nsathyaseelan @anusha94