Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Add environment argument to TaskBase._run_task() and Workflow subclass #739

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

ghisvail
Copy link
Collaborator

@ghisvail ghisvail commented Mar 22, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Summary

I bumped the Pydra version used by Clinica to 0.23 and ran the test suite.

There are a few failures, but one caught my attention in particular:

----------------------------- Captured stdout call -----------------------------
in SUBM None
_run_task() got an unexpected keyword argument 'environment'

The first line is a residual print statement (removed by the first commit).

The second one suggests an interface mismatch (fixed by the second commit).

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (e284b65) to head (14d1e19).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
- Coverage   84.28%   84.27%   -0.01%     
==========================================
  Files          26       26              
  Lines        5128     5127       -1     
  Branches     1447     1447              
==========================================
- Hits         4322     4321       -1     
  Misses        800      800              
  Partials        6        6              
Flag Coverage Δ
unittests 84.27% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@effigies effigies changed the title Some bug fixes when testing Clinica workflows FIX: Add environment argument to TaskBase._run_task() and Workflow subclass Mar 22, 2024
@effigies effigies merged commit e52e32b into nipype:master Mar 22, 2024
43 checks passed
@ghisvail ghisvail deleted the bug/workflow-fixes branch March 23, 2024 07:22
@tclose
Copy link
Contributor

tclose commented Mar 24, 2024

How did the environment kwarg get dropped? Was this something I introduced merging in my branches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants