Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test with Python 3.12 #730

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Test with Python 3.12 #730

merged 2 commits into from
Feb 9, 2024

Conversation

ghisvail
Copy link
Collaborator

@ghisvail ghisvail commented Feb 9, 2024

This PR enables testing by CI with Python 3.12.

I took this opportunity to enable caching of pip dependencies,
to save setup time and bandwidth.

It also drops exclusion of Python 3.11.1 from requires-python.

This is not a good practice as it can mess up with dependency
resolution for downstream projects depending on Pydra.

Instead, if such exclusion really is necessary, version guards
should be put in place where the specific feature impacted by
a regression in the language.

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69f27ad) 83.35% compared to head (646ac01) 79.26%.

❗ Current head 646ac01 differs from pull request most recent head bd8b733. Consider uploading reports for the commit bd8b733 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
- Coverage   83.35%   79.26%   -4.09%     
==========================================
  Files          24       24              
  Lines        4949     4949              
  Branches     1411     1411              
==========================================
- Hits         4125     3923     -202     
- Misses        816      830      +14     
- Partials        8      196     +188     
Flag Coverage Δ
unittests 79.08% <ø> (-4.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ghisvail ghisvail force-pushed the maint/py312 branch 2 times, most recently from 646ac01 to bd8b733 Compare February 9, 2024 13:31
@ghisvail ghisvail merged commit 07a048a into nipype:master Feb 9, 2024
43 checks passed
@ghisvail ghisvail deleted the maint/py312 branch February 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant