Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Enable testing with Python 3.11 #601

Merged
merged 4 commits into from
Nov 29, 2022
Merged

FIX: Enable testing with Python 3.11 #601

merged 4 commits into from
Nov 29, 2022

Conversation

ghisvail
Copy link
Collaborator

@ghisvail ghisvail commented Nov 28, 2022

Fails due to asyncio.wait now forbidding coroutines directly. Those need to be wrapped in tasks first.

Closes #569

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 76.81% // Head: 76.88% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (4bf6ca1) compared to base (aabee8e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #601      +/-   ##
==========================================
+ Coverage   76.81%   76.88%   +0.06%     
==========================================
  Files          19       19              
  Lines        4357     4357              
  Branches     1194     1258      +64     
==========================================
+ Hits         3347     3350       +3     
+ Misses        821      818       -3     
  Partials      189      189              
Flag Coverage Δ
unittests 76.79% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/workers.py 18.76% <ø> (ø)
pydra/engine/helpers.py 80.61% <0.00%> (+0.70%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghisvail ghisvail force-pushed the ci/test-python-3.11 branch 3 times, most recently from d196fa9 to 20b7a51 Compare November 29, 2022 14:50
@ghisvail ghisvail changed the title CI: Add Python 3.11 to test matrix FIX: Enable testing with Python 3.11 Nov 29, 2022
@effigies effigies merged commit 90f3032 into master Nov 29, 2022
@ghisvail ghisvail deleted the ci/test-python-3.11 branch November 30, 2022 11:17
@ghisvail
Copy link
Collaborator Author

Might be worth doing a new release with this fix for those working (or running tests) with Python 3.11.

@djarecka
Copy link
Collaborator

yes, will do it tonight! Want to add one more thing before release.

@djarecka
Copy link
Collaborator

@ghisvail - btw. can you please add yourself to the zenodo file, looks like you're still not there

@effigies
Copy link
Contributor

@ghisvail - btw. can you please add yourself to the zenodo file, looks like you're still not there

I knew I was forgetting something. Thanks for suggesting it!

@ghisvail
Copy link
Collaborator Author

I am pretty sure both of you asked me at least once to do it 😆

It's done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants