Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding an Attribute Error to the exception for get_value #592

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

djarecka
Copy link
Collaborator

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

this should "fix" the issue from #577, if output is None we should enter the exception block

Checklist

  • I have added tests to cover my changes (if necessary)
  • I have updated documentation (if necessary)

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Base: 76.74% // Head: 76.79% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (a12730d) compared to base (4d6a65b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #592      +/-   ##
==========================================
+ Coverage   76.74%   76.79%   +0.04%     
==========================================
  Files          19       19              
  Lines        4339     4339              
  Branches     1192     1192              
==========================================
+ Hits         3330     3332       +2     
+ Misses        821      818       -3     
- Partials      188      189       +1     
Flag Coverage Δ
unittests 76.69% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/core.py 89.28% <100.00%> (ø)
pydra/engine/helpers.py 80.61% <0.00%> (+0.47%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djarecka djarecka merged commit f72193e into nipype:master Oct 23, 2022
@djarecka djarecka deleted the fix/out_error branch December 30, 2022 20:32
@djarecka djarecka restored the fix/out_error branch December 30, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant