-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP-Adding software version retrieval #580
Conversation
Codecov ReportBase: 77.13% // Head: 76.77% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #580 +/- ##
==========================================
- Coverage 77.13% 76.77% -0.36%
==========================================
Files 20 19 -1
Lines 4330 4349 +19
Branches 1217 1193 -24
==========================================
- Hits 3340 3339 -1
- Misses 802 821 +19
- Partials 188 189 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@rcali21 - have you seen the errors from the tests. Please let me know if something is not clear from the error messages. Also, it would be good to expand the tests to check this specific change (after you fix the current tests) |
Yes, I will be working on resolving them and building a test, thank you. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@djarecka Please weigh in on this when you see it, thank you. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Would the singularity and SLURM calls be failing because I implemented something that uses stdout? |
don't worry about Singularity right now, I think it might be unrelated. Will try to check it locally |
@rcali21 - I fixed the issue with SIngularity, you could merge the current master to your branch and the tests should pass |
thanks for adding a test, but perhaps you can also add version check to the previous test: |
No description provided.