Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP-Adding software version retrieval #580

Merged
merged 24 commits into from
Oct 28, 2022
Merged

Conversation

rcali21
Copy link
Contributor

@rcali21 rcali21 commented Sep 19, 2022

No description provided.

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Base: 77.13% // Head: 76.77% // Decreases project coverage by -0.35% ⚠️

Coverage data is based on head (4b9df08) compared to base (67f7e72).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #580      +/-   ##
==========================================
- Coverage   77.13%   76.77%   -0.36%     
==========================================
  Files          20       19       -1     
  Lines        4330     4349      +19     
  Branches     1217     1193      -24     
==========================================
- Hits         3340     3339       -1     
- Misses        802      821      +19     
- Partials      188      189       +1     
Flag Coverage Δ
unittests 76.68% <100.00%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/audit.py 91.66% <100.00%> (+1.34%) ⬆️
pydra/engine/submitter.py 77.84% <0.00%> (-10.48%) ⬇️
pydra/engine/specs.py 88.00% <0.00%> (-0.59%) ⬇️
pydra/__init__.py
pydra/engine/core.py 89.28% <0.00%> (+0.20%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djarecka
Copy link
Collaborator

@rcali21 - have you seen the errors from the tests. Please let me know if something is not clear from the error messages.

Also, it would be good to expand the tests to check this specific change (after you fix the current tests)

@rcali21
Copy link
Contributor Author

rcali21 commented Oct 14, 2022

Yes, I will be working on resolving them and building a test, thank you.

@rcali21 rcali21 changed the title WIP-Adding i/o tracking in PROV WIP-Adding software version retrieval Oct 14, 2022
@rcali21
Copy link
Contributor Author

rcali21 commented Oct 15, 2022

@djarecka Please weigh in on this when you see it, thank you.

@rcali21
Copy link
Contributor Author

rcali21 commented Oct 15, 2022

Would the singularity and SLURM calls be failing because I implemented something that uses stdout?

@djarecka
Copy link
Collaborator

don't worry about Singularity right now, I think it might be unrelated. Will try to check it locally

@djarecka
Copy link
Collaborator

@rcali21 - I fixed the issue with SIngularity, you could merge the current master to your branch and the tests should pass

@djarecka
Copy link
Collaborator

thanks for adding a test, but perhaps you can also add version check to the previous test: test_audit_task

@djarecka djarecka merged commit 5bbb4a9 into nipype:master Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants