Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inspect.getfullargspec instead of getargspec #568

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

ghisvail
Copy link
Collaborator

The latter triggers deprecation warnings since Python 3.0. Using
getfullargspec instead which provides a compatible return type.

The latter triggers deprecation warnings since Python 3.0. Using
`getfullargspec` instead which provides a compatible return type.
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #568 (be10ffe) into master (ac06f8c) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #568      +/-   ##
==========================================
- Coverage   77.13%   77.06%   -0.07%     
==========================================
  Files          20       20              
  Lines        4316     4316              
  Branches     1212     1212              
==========================================
- Hits         3329     3326       -3     
- Misses        799      802       +3     
  Partials      188      188              
Flag Coverage Δ
unittests 76.96% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/specs.py 88.59% <100.00%> (ø)
pydra/engine/task.py 86.76% <100.00%> (ø)
pydra/engine/helpers.py 79.90% <0.00%> (-0.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@djarecka djarecka merged commit 6425ac9 into nipype:master Aug 17, 2022
@ghisvail ghisvail deleted the fix/warn-inspect branch March 8, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants