Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing two tests #514

Merged
merged 1 commit into from
Mar 20, 2022
Merged

fixing two tests #514

merged 1 commit into from
Mar 20, 2022

Conversation

djarecka
Copy link
Collaborator

some tests were failing after merging #504

Acknowledgment

  • I acknowledge that this contribution will be available under the Apache 2 license.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Summary

Checklist

  • All tests passing
  • I have added tests to cover my changes
  • I have updated documentation (if necessary)
  • My code follows the code style of this project
    (we are using black: you can pip install pre-commit,
    run pre-commit install in the pydra directory
    and black will be run automatically with each commit)

@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #514 (9cbb2dd) into master (1f96fcf) will increase coverage by 39.25%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #514       +/-   ##
===========================================
+ Coverage   39.64%   78.89%   +39.25%     
===========================================
  Files          20       20               
  Lines        4326     4326               
  Branches     1211     1211               
===========================================
+ Hits         1715     3413     +1698     
+ Misses       2285      721     -1564     
+ Partials      326      192      -134     
Flag Coverage Δ
unittests 78.82% <ø> (+39.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pydra/engine/workers.py 18.62% <0.00%> (+1.49%) ⬆️
pydra/conftest.py 55.55% <0.00%> (+16.66%) ⬆️
pydra/__init__.py 95.00% <0.00%> (+20.00%) ⬆️
pydra/engine/submitter.py 84.66% <0.00%> (+20.66%) ⬆️
pydra/engine/core.py 89.25% <0.00%> (+30.33%) ⬆️
pydra/engine/specs.py 88.13% <0.00%> (+35.59%) ⬆️
pydra/engine/helpers_file.py 80.48% <0.00%> (+35.97%) ⬆️
pydra/engine/helpers.py 79.57% <0.00%> (+39.42%) ⬆️
pydra/engine/task.py 87.85% <0.00%> (+41.52%) ⬆️
pydra/utils/profiler.py 43.51% <0.00%> (+43.51%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f96fcf...9cbb2dd. Read the comment docs.

@djarecka djarecka merged commit 6a6ca40 into nipype:master Mar 20, 2022
@djarecka djarecka deleted the fix/file_tests branch March 21, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant