-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duecredit citation #6
Conversation
Alternative dirty solution-- copy/paste |
looks ok to me ;) did you try on some ? did it work? ;) $> ./quickshear.py /home/yoh/datalad_aside2/labs/haxby/raiders/sub001/anatomy/highres004_deface{d.nii.gz,mask.nii.gz} defaced
Traceback (most recent call last):
File "./quickshear.py", line 226, in <module>
sys.exit(main(*sys.argv))
File "./quickshear.py", line 220, in main
new_anat = quickshear(anat_img, mask_img, opts.buffer)
File "./quickshear.py", line 176, in quickshear
xdiffs, ydiffs = np.diff(low)
ValueError: need more than 0 values to unpack |
It's worked for me on the subjects I've tried. Could you make the brainmask available? This is an issue with the convex hull, it looks like, so I won't need the anatomical to assess. Also, have you tried with v1.0? I did switch to using nice numpy functions where possible, but the hand-written code might give more informative errors. (Or work and show the things I thought equivalent weren't.) |
all (well -- defaced and functionals) data is there online at http://datasets.datalad.org/?dir=/labs/haxby/raiders/sub001/anatomy/ . didn't crash with v1.0: $> ./quickshear.py /home/yoh/datalad_aside2/labs/haxby/raiders/sub001/anatomy/highres004_deface{d.nii.gz,mask.nii.gz} defaced
Anat image axes: ('P', 'S', 'R')
Mask image axes: ('P', 'S', 'R')
Mask shape!: (256, 256, 160)
Aligning anatomical image to +x -> P
Aligning mask to +x -> P
Aligning anatomical image to +y -> S
Aligning mask to +y -> S
Defaced file: defaced |
@yarikoptic I see the problem. The code originally assumed (and still does) that the axes were always |
Also, that defacemask is not a brainmask, which is what quickshear needs. You're probably running into an issue with the fact that it's assuming you have a roughly brain-shaped mask. |
@yarikoptic: How does this look? And does it make more sense to put it at the module level for something this small, or to decorate the core function?
I haven't dug much into
duecredit
, so I'm not really sure why you'd choose one or the other.Closes #5.