fix: Remove pkg_resources dependency #230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reasonable case where a user has pkg_resources-accessible metadata (or importlib-metadata) and does not have a `_version.py` file. Instead of replacing with importlib-metadata, I'm just skipping ahead to the hard-coded "unknown", using `0+unknown` to satisfy PEP440. There may be a very rare case where someone makes an editable installation and borks their directory, but knowing what the version was when they installed it won't help us a lot there.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 93.01% 95.32% +2.31%
==========================================
Files 28 28
Lines 2976 2953 -23
==========================================
+ Hits 2768 2815 +47
+ Misses 208 138 -70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reasonable case where a user has pkg_resources-accessible metadata (or importlib-metadata) and does not have a
_version.pyfile.Instead of replacing with importlib-metadata, I'm just skipping ahead to the hard-coded "unknown", using
0+unknownto satisfy PEP440.There may be a very rare case where someone makes an editable installation and borks their directory, but knowing what the version was when they installed it won't help us a lot there.