Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: increase coverage #23

Merged
merged 3 commits into from
Oct 22, 2019
Merged

enh: increase coverage #23

merged 3 commits into from
Oct 22, 2019

Conversation

mgxd
Copy link
Member

@mgxd mgxd commented Oct 22, 2019

bump up testing coverage, mainly for base and linear modules.

also adds a missing assertion for LTA test.

@codecov-io
Copy link

codecov-io commented Oct 22, 2019

Codecov Report

Merging #23 into master will increase coverage by 4.83%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
+ Coverage    72.2%   77.04%   +4.83%     
==========================================
  Files          10       11       +1     
  Lines         734      758      +24     
  Branches       92       92              
==========================================
+ Hits          530      584      +54     
+ Misses        167      136      -31     
- Partials       37       38       +1
Flag Coverage Δ
#unittests 77.04% <100%> (+4.83%) ⬆️
Impacted Files Coverage Δ
nitransforms/linear.py 70.05% <ø> (+10.16%) ⬆️
nitransforms/tests/test_transform.py 85% <100%> (+2.24%) ⬆️
nitransforms/tests/test_io.py 100% <100%> (ø) ⬆️
nitransforms/tests/test_base.py 100% <100%> (ø)
nitransforms/base.py 73.03% <0%> (+12.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ab68b3...3552e4f. Read the comment docs.

@oesteban oesteban merged commit 94445d9 into nipy:master Oct 22, 2019
@mgxd mgxd deleted the enh/cov branch October 31, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants